From: Peter Zijlstra Add Peter's comment to Nick's patch. Cc: Nick Piggin Cc: Petr Tesarik Signed-off-by: Peter Zijlstra Signed-off-by: Andrew Morton --- fs/exec.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff -puN fs/exec.c~exec-fix-remove_arg_zero-add-comment fs/exec.c --- a/fs/exec.c~exec-fix-remove_arg_zero-add-comment +++ a/fs/exec.c @@ -982,9 +982,13 @@ void compute_creds(struct linux_binprm * task_unlock(current); security_bprm_post_apply_creds(bprm); } - EXPORT_SYMBOL(compute_creds); +/* + * Arguments are '\0' separated strings found at the location bprm->p + * points to; chop off the first by relocating brpm->p to right after + * the first '\0' encountered. + */ void remove_arg_zero(struct linux_binprm *bprm) { if (bprm->argc) { @@ -1023,7 +1027,6 @@ void remove_arg_zero(struct linux_binprm bprm->argc--; } } - EXPORT_SYMBOL(remove_arg_zero); /* _