From: Andrew Morton expression-with-side-effects inside an assertion is not a good idea. Cc: Christoph Lameter Signed-off-by: Andrew Morton --- mm/slub.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -puN mm/slub.c~slub-core-tidy-8 mm/slub.c --- a/mm/slub.c~slub-core-tidy-8 +++ a/mm/slub.c @@ -1696,7 +1696,8 @@ void kmem_cache_destroy(struct kmem_cach s->refcount--; else { list_del(&s->list); - WARN_ON(kmem_cache_close(s)); + if (kmem_cache_close(s)) + WARN_ON(1); sysfs_slab_remove(s); kfree(s); } _