From: Andrew Morton arch/i386/pci/irq.c: In function 'pirq_pico_set': arch/i386/pci/irq.c:510: warning: no return statement in function returning non-void arch/i386/pci/irq.c:510: warning: control reaches end of non-void function Cc: Thomas Backlund Signed-off-by: Andrew Morton --- arch/i386/pci/irq.c | 4 +++- linux/pci_ids.h | 0 2 files changed, 3 insertions(+), 1 deletion(-) diff -puN arch/i386/pci/irq.c~i386-add-support-for-picopower-irq-router-fix arch/i386/pci/irq.c --- a/arch/i386/pci/irq.c~i386-add-support-for-picopower-irq-router-fix +++ a/arch/i386/pci/irq.c @@ -500,13 +500,15 @@ static int pirq_pico_get(struct pci_dev return ((pirq - 1) & 1) ? (inb(0x26) >> 4) : (inb(0x26) & 0xf); } -static int pirq_pico_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq) +static int pirq_pico_set(struct pci_dev *router, struct pci_dev *dev, int pirq, + int irq) { unsigned int x; outb(0x10 + ((pirq - 1) >> 1), 0x24); x = inb(0x26); x = ((pirq - 1) & 1) ? ((x & 0x0f) | (irq << 4)) : ((x & 0xf0) | (irq)); outb(x, 0x26); + return 1; } #ifdef CONFIG_PCI_BIOS diff -puN include/linux/pci_ids.h~i386-add-support-for-picopower-irq-router-fix include/linux/pci_ids.h _