From: Alexey Dobriyan module_get_kallsym() could in theory truncate module symbol name to fit in buffer, but nobody does this. Always use KSYM_NAME_LEN + 1 bytes for name. Suggested by lg^WRusty. Signed-off-by: Alexey Dobriyan Acked-by: Rusty Russell Signed-off-by: Andrew Morton --- include/linux/module.h | 5 ++--- kernel/kallsyms.c | 2 +- kernel/module.c | 5 +++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff -puN include/linux/module.h~simplify-module_get_kallsym-by-dropping-length-arg include/linux/module.h --- a/include/linux/module.h~simplify-module_get_kallsym-by-dropping-length-arg +++ a/include/linux/module.h @@ -374,7 +374,7 @@ int is_module_address(unsigned long addr /* Returns module and fills in value, defined and namebuf, or NULL if symnum out of range. */ struct module *module_get_kallsym(unsigned int symnum, unsigned long *value, - char *type, char *name, size_t namelen); + char *type, char *name); /* Look for this name: can be of form module:name. */ unsigned long module_kallsyms_lookup_name(const char *name); @@ -532,8 +532,7 @@ static inline const char *module_address static inline struct module *module_get_kallsym(unsigned int symnum, unsigned long *value, - char *type, char *name, - size_t namelen) + char *type, char *name) { return NULL; } diff -puN kernel/kallsyms.c~simplify-module_get_kallsym-by-dropping-length-arg kernel/kallsyms.c --- a/kernel/kallsyms.c~simplify-module_get_kallsym-by-dropping-length-arg +++ a/kernel/kallsyms.c @@ -312,7 +312,7 @@ static int get_ksymbol_mod(struct kallsy { iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms, &iter->value, &iter->type, - iter->name, sizeof(iter->name)); + iter->name); if (iter->owner == NULL) return 0; diff -puN kernel/module.c~simplify-module_get_kallsym-by-dropping-length-arg kernel/module.c --- a/kernel/module.c~simplify-module_get_kallsym-by-dropping-length-arg +++ a/kernel/module.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -2202,7 +2203,7 @@ const char *module_address_lookup(unsign } struct module *module_get_kallsym(unsigned int symnum, unsigned long *value, - char *type, char *name, size_t namelen) + char *type, char *name) { struct module *mod; @@ -2212,7 +2213,7 @@ struct module *module_get_kallsym(unsign *value = mod->symtab[symnum].st_value; *type = mod->symtab[symnum].st_info; strlcpy(name, mod->strtab + mod->symtab[symnum].st_name, - namelen); + KSYM_NAME_LEN + 1); mutex_unlock(&module_mutex); return mod; } _