From: Andrew Morton If this mutex_lock_interruptible() does fail due to signal_pending() then the state of the driver will get trashed in interesting ways, because userspace cannot and will not retry the close(). Cc: Mauro Carvalho Chehab Cc: Jiri Slaby Signed-off-by: Andrew Morton --- drivers/media/dvb/cinergyT2/cinergyT2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/media/dvb/cinergyT2/cinergyT2.c~cinergyt2-fix-file-release-handler drivers/media/dvb/cinergyT2/cinergyT2.c --- a/drivers/media/dvb/cinergyT2/cinergyT2.c~cinergyt2-fix-file-release-handler +++ a/drivers/media/dvb/cinergyT2/cinergyT2.c @@ -519,8 +519,7 @@ static int cinergyt2_release (struct ino struct dvb_device *dvbdev = file->private_data; struct cinergyt2 *cinergyt2 = dvbdev->priv; - if (mutex_lock_interruptible(&cinergyt2->sem)) - return -ERESTARTSYS; + mutex_lock(&cinergyt2->sem); if (!cinergyt2->disconnect_pending && (file->f_flags & O_ACCMODE) != O_RDONLY) { cancel_delayed_work(&cinergyt2->query_work); _