From: Simon Arlott The sysfs adsl_status attribute ignores (aside from returning -EIO to the user) any error sending a START/STOP command to the device and there is at least one firmware which never sends a response but appears to work regardless. Therefore atm_start should also continue if an error is received so that such firmware is usable. The official Conexant driver doesn't expect a reply either but this is for another device (E2 router) and a commonly used firmware does respond. Also, there is no point in changing -ECONNRESET to -ETIMEDOUT since nothing ever checks for either of these values. Signed-off-by: Simon Arlott Cc: Duncan Sands Signed-off-by: Andrew Morton --- drivers/usb/atm/cxacru.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff -puN drivers/usb/atm/cxacru.c~cxacru-ignore-error-trying-to-start-adsl-in-atm_start drivers/usb/atm/cxacru.c --- a/drivers/usb/atm/cxacru.c~cxacru-ignore-error-trying-to-start-adsl-in-atm_start +++ a/drivers/usb/atm/cxacru.c @@ -465,8 +465,6 @@ static int cxacru_start_wait_urb(struct add_timer(&timer); wait_for_completion(done); status = urb->status; - if (status == -ECONNRESET) - status = -ETIMEDOUT; del_timer_sync(&timer); if (actual_length) @@ -660,11 +658,8 @@ static int cxacru_atm_start(struct usbat /* start ADSL */ mutex_lock(&instance->adsl_state_serialize); ret = cxacru_cm(instance, CM_REQUEST_CHIP_ADSL_LINE_START, NULL, 0, NULL, 0); - if (ret < 0) { + if (ret < 0) atm_err(usbatm_instance, "cxacru_atm_start: CHIP_ADSL_LINE_START returned %d\n", ret); - mutex_unlock(&instance->adsl_state_serialize); - return ret; - } /* Start status polling */ mutex_lock(&instance->poll_state_serialize); _