From htejun@gmail.com Wed Jun 13 11:45:43 2007 From: Tejun Heo Cc: Tejun Heo , Greg Kroah-Hartman Subject: [PATCH 24/31] sysfs: fix parent refcounting during rename and move Date: Thu, 14 Jun 2007 03:45:17 +0900 Message-Id: <11817603173097-git-send-email-htejun@gmail.com> To: greg@kroah.com, rjw@sisk.pl, akpm@linux-foundation.org, htejun@gmail.com From: Tejun Heo Parent reference wasn't properly transferred during rename and move. Fix it. Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/dir.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -497,6 +497,9 @@ int sysfs_rename_dir(struct kobject * ko d_move(kobj->dentry, new_dentry); list_del_init(&sd->s_sibling); + sysfs_get(parent_sd); + sysfs_put(sd->s_parent); + sd->s_parent = parent_sd; list_add(&sd->s_sibling, &parent_sd->s_children); error = 0; @@ -550,6 +553,9 @@ again: /* Remove from old parent's list and insert into new parent's list. */ list_del_init(&sd->s_sibling); + sysfs_get(new_parent_sd); + sysfs_put(sd->s_parent); + sd->s_parent = new_parent_sd; list_add(&sd->s_sibling, &new_parent_sd->s_children); out: