From: vignesh babu Replace (n & (n-1)) in the context of power of 2 checks with is_power_of_2(). Signed-off-by: vignesh babu Signed-off-by: Andrew Morton --- fs/jbd/revoke.c | 5 +++-- fs/jbd2/revoke.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff -puN fs/jbd/revoke.c~is_power_of_2-jbd fs/jbd/revoke.c --- a/fs/jbd/revoke.c~is_power_of_2-jbd +++ a/fs/jbd/revoke.c @@ -68,6 +68,7 @@ #include #include #endif +#include static struct kmem_cache *revoke_record_cache; static struct kmem_cache *revoke_table_cache; @@ -215,7 +216,7 @@ int journal_init_revoke(journal_t *journ journal->j_revoke = journal->j_revoke_table[0]; /* Check that the hash_size is a power of two */ - J_ASSERT ((hash_size & (hash_size-1)) == 0); + J_ASSERT(is_power_of_2(hash_size)); journal->j_revoke->hash_size = hash_size; @@ -242,7 +243,7 @@ int journal_init_revoke(journal_t *journ journal->j_revoke = journal->j_revoke_table[1]; /* Check that the hash_size is a power of two */ - J_ASSERT ((hash_size & (hash_size-1)) == 0); + J_ASSERT(is_power_of_2(hash_size)); journal->j_revoke->hash_size = hash_size; diff -puN fs/jbd2/revoke.c~is_power_of_2-jbd fs/jbd2/revoke.c --- a/fs/jbd2/revoke.c~is_power_of_2-jbd +++ a/fs/jbd2/revoke.c @@ -68,6 +68,7 @@ #include #include #endif +#include static struct kmem_cache *jbd2_revoke_record_cache; static struct kmem_cache *jbd2_revoke_table_cache; @@ -212,7 +213,7 @@ int jbd2_journal_init_revoke(journal_t * journal->j_revoke = journal->j_revoke_table[0]; /* Check that the hash_size is a power of two */ - J_ASSERT ((hash_size & (hash_size-1)) == 0); + J_ASSERT(is_power_of_2(hash_size)); journal->j_revoke->hash_size = hash_size; @@ -239,7 +240,7 @@ int jbd2_journal_init_revoke(journal_t * journal->j_revoke = journal->j_revoke_table[1]; /* Check that the hash_size is a power of two */ - J_ASSERT ((hash_size & (hash_size-1)) == 0); + J_ASSERT(is_power_of_2(hash_size)); journal->j_revoke->hash_size = hash_size; _