From: Mariusz Kozlowski Is this a bug? In original verison memset cleared sizeof(state) bytes instead of sizeof(*state). If it was intentional then this patch is invalid. If not intentional -> valid :) Please review. drivers/ide/arm/icside.c | 18883 -> 18849 (-34 bytes) Signed-off-by: Mariusz Kozlowski Cc: Russell King Cc: Bartlomiej Zolnierkiewicz Signed-off-by: Andrew Morton --- drivers/ide/arm/icside.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/ide/arm/icside.c~drivers-ide-arm-icsidec-kmalloc-memset-conversion-to-kzalloc drivers/ide/arm/icside.c --- a/drivers/ide/arm/icside.c~drivers-ide-arm-icsidec-kmalloc-memset-conversion-to-kzalloc +++ a/drivers/ide/arm/icside.c @@ -682,13 +682,12 @@ icside_probe(struct expansion_card *ec, if (ret) goto out; - state = kmalloc(sizeof(struct icside_state), GFP_KERNEL); + state = kzalloc(sizeof(struct icside_state), GFP_KERNEL); if (!state) { ret = -ENOMEM; goto release; } - memset(state, 0, sizeof(state)); state->type = ICS_TYPE_NOTYPE; state->dev = &ec->dev; _