From: Mariusz Kozlowski drivers/media/video/msp3400-driver.c | 28945 -> 28898 (-47 bytes) drivers/media/video/msp3400-driver.o | 125620 -> 125320 (-300 bytes) Signed-off-by: Mariusz Kozlowski Cc: Mauro Carvalho Chehab Signed-off-by: Andrew Morton --- drivers/media/video/msp3400-driver.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff -puN drivers/media/video/msp3400-driver.c~drivers-media-video-msp3400-driverc-kmalloc-memset-conversion-to-kzalloc drivers/media/video/msp3400-driver.c --- a/drivers/media/video/msp3400-driver.c~drivers-media-video-msp3400-driverc-kmalloc-memset-conversion-to-kzalloc +++ a/drivers/media/video/msp3400-driver.c @@ -813,8 +813,9 @@ static int msp_attach(struct i2c_adapter int msp_rom; client = kzalloc(sizeof(*client), GFP_KERNEL); - if (client == NULL) + if (!client) return -ENOMEM; + client->addr = address; client->adapter = adapter; client->driver = &i2c_driver; @@ -826,14 +827,14 @@ static int msp_attach(struct i2c_adapter return 0; } - state = kmalloc(sizeof(*state), GFP_KERNEL); - if (state == NULL) { + state = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) { kfree(client); return -ENOMEM; } + i2c_set_clientdata(client, state); - memset(state, 0, sizeof(*state)); state->v4l2_std = V4L2_STD_NTSC; state->audmode = V4L2_TUNER_MODE_STEREO; state->volume = 58880; /* 0db gain */ _