From: WANG Cong - There are no lists in fs/romfs/inode.c, so using list_entry is a bit confusing. Replace it with container_of. - It is unnecessary to cast the return value of kmem_cache_alloc, since it returns a void* pointer. Signed-off-by: WANG Cong Signed-off-by: Andrew Morton --- fs/romfs/inode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/romfs/inode.c~fs-romfs-inodec-trivial-improvements fs/romfs/inode.c --- a/fs/romfs/inode.c~fs-romfs-inodec-trivial-improvements +++ a/fs/romfs/inode.c @@ -92,7 +92,7 @@ static inline unsigned long romfs_maxsiz static inline struct romfs_inode_info *ROMFS_I(struct inode *inode) { - return list_entry(inode, struct romfs_inode_info, vfs_inode); + return container_of(inode, struct romfs_inode_info, vfs_inode); } static __u32 @@ -555,7 +555,7 @@ static struct kmem_cache * romfs_inode_c static struct inode *romfs_alloc_inode(struct super_block *sb) { struct romfs_inode_info *ei; - ei = (struct romfs_inode_info *)kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL); + ei = kmem_cache_alloc(romfs_inode_cachep, GFP_KERNEL); if (!ei) return NULL; return &ei->vfs_inode; _