From: Josh Triplett Nothing outside of arch/i386/kernel/i8253.c uses pit_clockevent, so mark it static. Eliminates a sparse warning: warning: symbol 'pit_clockevent' was not declared. Should it be static? Signed-off-by: Josh Triplett Cc: Andi Kleen Signed-off-by: Andrew Morton --- arch/i386/kernel/i8253.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/kernel/i8253.c~i386-mark-pit_clockevent-static arch/i386/kernel/i8253.c --- a/arch/i386/kernel/i8253.c~i386-mark-pit_clockevent-static +++ a/arch/i386/kernel/i8253.c @@ -91,7 +91,7 @@ static int pit_next_event(unsigned long * registered. This mechanism replaces the previous #ifdef LOCAL_APIC - * !using_apic_timer decisions in do_timer_interrupt_hook() */ -struct clock_event_device pit_clockevent = { +static struct clock_event_device pit_clockevent = { .name = "pit", .features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT, .set_mode = init_pit_timer, _