From: "J. Bruce Fields" There's no need for another variable local to this loop; we can use the variable (of the same name!) already declared at the top of the function, and not used till later (at which point it's initialized, so this is safe). Signed-off-by: J. Bruce Fields Signed-off-by: Trond Myklebust Signed-off-by: Andrew Morton --- fs/locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/locks.c~locks-kill-redundant-local-variable fs/locks.c --- a/fs/locks.c~locks-kill-redundant-local-variable +++ a/fs/locks.c @@ -819,7 +819,7 @@ static int __posix_lock_file(struct inod lock_kernel(); if (request->fl_type != F_UNLCK) { for_each_lock(inode, before) { - struct file_lock *fl = *before; + fl = *before; if (!IS_POSIX(fl)) continue; if (!posix_locks_conflict(request, fl)) _