From: Andrew Morton clean up some crap while we're there. Cc: Matthias Kaehlcke Signed-off-by: Andrew Morton --- fs/super.c | 18 ++++++++++-------- 1 files changed, 10 insertions(+), 8 deletions(-) diff -puN fs/super.c~fs-superc-use-list_for_each_entry-instead-of-list_for_each-fix fs/super.c --- a/fs/super.c~fs-superc-use-list_for_each_entry-instead-of-list_for_each-fix +++ a/fs/super.c @@ -337,14 +337,16 @@ struct super_block *sget(struct file_sys retry: spin_lock(&sb_lock); - if (test) list_for_each_entry(old, &type->fs_supers, s_instances) { - if (!test(old, data)) - continue; - if (!grab_super(old)) - goto retry; - if (s) - destroy_super(s); - return old; + if (test) { + list_for_each_entry(old, &type->fs_supers, s_instances) { + if (!test(old, data)) + continue; + if (!grab_super(old)) + goto retry; + if (s) + destroy_super(s); + return old; + } } if (!s) { spin_unlock(&sb_lock); _