From: Jeff Dike I messed up the error cleanup ordering in the console port driver. Signed-off-by: Jeff Dike Cc: Paolo 'Blaisorblade' Giarrusso Signed-off-by: Andrew Morton --- arch/um/drivers/port_kern.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN arch/um/drivers/port_kern.c~uml-fix-error-cleanup-ordering arch/um/drivers/port_kern.c --- a/arch/um/drivers/port_kern.c~uml-fix-error-cleanup-ordering +++ a/arch/um/drivers/port_kern.c @@ -216,10 +216,10 @@ void *port_data(int port_num) .telnetd_pid = -1 }); goto out; - out_free: - kfree(port); out_close: os_close_file(fd); + out_free: + kfree(port); out: up(&ports_sem); return dev; _