From: Pavel Emelyanov The __mandatory_lock(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov Cc: David Howells Signed-off-by: Andrew Morton --- fs/afs/flock.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN fs/afs/flock.c~afs-cleanup-explicit-check-for-mandatory-locks fs/afs/flock.c --- a/fs/afs/flock.c~afs-cleanup-explicit-check-for-mandatory-locks +++ a/fs/afs/flock.c @@ -524,8 +524,7 @@ int afs_lock(struct file *file, int cmd, (long long) fl->fl_start, (long long) fl->fl_end); /* AFS doesn't support mandatory locks */ - if ((vnode->vfs_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID && - fl->fl_type != F_UNLCK) + if (__mandatory_lock(&vnode->vfs_inode) && fl->fl_type != F_UNLCK) return -ENOLCK; if (IS_GETLK(cmd)) _