From: Pavel Emelyanov The __mandatory_lock(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov Cc: Trond Myklebust Cc: "J. Bruce Fields" Signed-off-by: Andrew Morton --- fs/nfs/file.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN fs/nfs/file.c~nfs-cleanup-explicit-check-for-mandatory-locks fs/nfs/file.c --- a/fs/nfs/file.c~nfs-cleanup-explicit-check-for-mandatory-locks +++ a/fs/nfs/file.c @@ -605,8 +605,7 @@ static int nfs_lock(struct file *filp, i nfs_inc_stats(inode, NFSIOS_VFSLOCK); /* No mandatory locks over NFS */ - if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID && - fl->fl_type != F_UNLCK) + if (__mandatory_lock(inode) && fl->fl_type != F_UNLCK) return -ENOLCK; if (IS_GETLK(cmd)) _