From: Coly Li When setup vm_page_prot, some code use 0x7 instead of (VM_READ|VM_WRITE|= VM_EXEC). It does works well, but it will be better if we use the VM_READ/WRITE/EXEC MACRO :-) This patch uses (VM_READ|VM_WRITE|VM_EXEC) to replace 0x7 in vm_page_prot= setup. Signed-off-by: Coly Li Cc: Hugh Dickins Cc: "Luck, Tony" Signed-off-by: Andrew Morton --- arch/ia64/mm/init.c | 3 ++- fs/exec.c | 3 ++- mm/mmap.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff -puN arch/ia64/mm/init.c~use-vm_read-write-exec-to-set-vm_page_prot arch/ia64/mm/init.c --- a/arch/ia64/mm/init.c~use-vm_read-write-exec-to-set-vm_page_prot +++ a/arch/ia64/mm/init.c @@ -130,7 +130,8 @@ ia64_init_addr_space (void) vma->vm_mm = current->mm; vma->vm_start = current->thread.rbs_bot & PAGE_MASK; vma->vm_end = vma->vm_start + PAGE_SIZE; - vma->vm_page_prot = protection_map[VM_DATA_DEFAULT_FLAGS & 0x7]; + vma->vm_page_prot = protection_map[VM_DATA_DEFAULT_FLAGS & + (VM_READ|VM_WRITE|VM_EXEC)]; vma->vm_flags = VM_DATA_DEFAULT_FLAGS|VM_GROWSUP|VM_ACCOUNT; down_write(¤t->mm->mmap_sem); if (insert_vm_struct(current->mm, vma)) { diff -puN fs/exec.c~use-vm_read-write-exec-to-set-vm_page_prot fs/exec.c --- a/fs/exec.c~use-vm_read-write-exec-to-set-vm_page_prot +++ a/fs/exec.c @@ -261,7 +261,8 @@ static int __bprm_mm_init(struct linux_b vma->vm_start = vma->vm_end - PAGE_SIZE; vma->vm_flags = VM_STACK_FLAGS; - vma->vm_page_prot = protection_map[vma->vm_flags & 0x7]; + vma->vm_page_prot = protection_map[vma->vm_flags & + (VM_READ|VM_WRITE|VM_EXEC)]; err = insert_vm_struct(mm, vma); if (err) { up_write(&mm->mmap_sem); diff -puN mm/mmap.c~use-vm_read-write-exec-to-set-vm_page_prot mm/mmap.c --- a/mm/mmap.c~use-vm_read-write-exec-to-set-vm_page_prot +++ a/mm/mmap.c @@ -2210,7 +2210,8 @@ int install_special_mapping(struct mm_st vma->vm_end = addr + len; vma->vm_flags = vm_flags | mm->def_flags; - vma->vm_page_prot = protection_map[vma->vm_flags & 7]; + vma->vm_page_prot = protection_map[vma->vm_flags & + (VM_READ|VM_WRITE|VM_EXEC)]; vma->vm_ops = &special_mapping_vmops; vma->vm_private_data = pages; _