From: Mariusz Kozlowski Documentation/firmware_class/firmware_sample_firmware_class.c | 5246 -> 5211 (-35 bytes) Signed-off-by: Mariusz Kozlowski Signed-off-by: Andrew Morton --- Documentation/firmware_class/firmware_sample_firmware_class.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff -puN Documentation/firmware_class/firmware_sample_firmware_class.c~doc-firmware_sample_firmware_classc-kmalloc-memset-conversion-to-kzalloc Documentation/firmware_class/firmware_sample_firmware_class.c --- a/Documentation/firmware_class/firmware_sample_firmware_class.c~doc-firmware_sample_firmware_classc-kmalloc-memset-conversion-to-kzalloc +++ a/Documentation/firmware_class/firmware_sample_firmware_class.c @@ -109,15 +109,15 @@ static int fw_setup_class_device(struct const char *fw_name, struct device *device) { - int retval = 0; - struct firmware_priv *fw_priv = kmalloc(sizeof(struct firmware_priv), - GFP_KERNEL); + int retval; + struct firmware_priv *fw_priv; - if(!fw_priv){ + fw_priv = kzalloc(sizeof(struct firmware_priv), GFP_KERNEL); + if (!fw_priv) { retval = -ENOMEM; goto out; } - memset(fw_priv, 0, sizeof(*fw_priv)); + memset(class_dev, 0, sizeof(*class_dev)); strncpy(fw_priv->fw_id, fw_name, FIRMWARE_NAME_MAX); _