From: Michael Halcrow On Wed, Sep 19, 2007 at 10:48:17PM -0700, Andrew Morton wrote: > On Mon, 17 Sep 2007 16:48:44 -0500 Michael Halcrow wrote: > > + if ((rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, > > checkpatch missed the assignment-in-an-if here. Fix an assignment-in-an-if. Signed-off-by: Michael Halcrow Signed-off-by: Andrew Morton --- fs/ecryptfs/crypto.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -puN fs/ecryptfs/crypto.c~ecryptfs-update-metadata-read-write-functions-cleanup fs/ecryptfs/crypto.c --- a/fs/ecryptfs/crypto.c~ecryptfs-update-metadata-read-write-functions-cleanup +++ a/fs/ecryptfs/crypto.c @@ -1455,8 +1455,9 @@ ecryptfs_write_metadata_to_contents(stru int header_pages; int rc; - if ((rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, page_virt, - 0, PAGE_CACHE_SIZE))) { + rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, page_virt, + 0, PAGE_CACHE_SIZE); + if (rc) { printk(KERN_ERR "%s: Error attempting to write header " "information to lower file; rc = [%d]\n", __FUNCTION__, rc); _