From: Geert Uytterhoeven Looking at the code flow, `int first' in fb_create_modedb() should be static. [adaplas] Better for 'int first' to be moved outside the loop. Signed-off-by: Geert Uytterhoeven Signed-off-by: Antonino Daplas Signed-off-by: Andrew Morton --- drivers/video/fbmon.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/video/fbmon.c~fbdev-fb_create_modedb-non-static-int-first-=-1 drivers/video/fbmon.c --- a/drivers/video/fbmon.c~fbdev-fb_create_modedb-non-static-int-first-=-1 +++ a/drivers/video/fbmon.c @@ -591,7 +591,9 @@ static struct fb_videomode *fb_create_mo { struct fb_videomode *mode, *m; unsigned char *block; - int num = 0, i; + int num = 0, i, first = 1; + +; mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL); if (mode == NULL) @@ -608,8 +610,6 @@ static struct fb_videomode *fb_create_mo DPRINTK(" Detailed Timings\n"); block = edid + DETAILED_TIMING_DESCRIPTIONS_START; for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) { - int first = 1; - if (!(block[0] == 0x00 && block[1] == 0x00)) { get_detailed_timing(block, &mode[num]); if (first) { _