From linux-kernel-owner+greg=40kroah.com-S1756538AbXIEFs4@vger.kernel.org Sun Sep 9 09:46:35 2007 From: Micah Gruber Date: Wed, 05 Sep 2007 13:49:58 +0800 Subject: USB: Remove unneeded pointer intf from speedtch_upload_firmware() To: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net Message-ID: <46DE4386.5050107@gmail.com> This trivial patch removes the unneeded pointer intf returned from usb_ifnum_to_if(), which is never used. The check for NULL can be simply done by if (!usb_ifnum_to_if(usb_dev, 2)). Signed-off-by: Micah Gruber Signed-off-by: Greg Kroah-Hartman --- drivers/usb/atm/speedtch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/usb/atm/speedtch.c +++ b/drivers/usb/atm/speedtch.c @@ -251,7 +251,6 @@ static int speedtch_upload_firmware(stru { unsigned char *buffer; struct usbatm_data *usbatm = instance->usbatm; - struct usb_interface *intf; struct usb_device *usb_dev = usbatm->usb_dev; int actual_length; int ret = 0; @@ -265,7 +264,7 @@ static int speedtch_upload_firmware(stru goto out; } - if (!(intf = usb_ifnum_to_if(usb_dev, 2))) { + if (!usb_ifnum_to_if(usb_dev, 2)) { ret = -ENODEV; usb_dbg(usbatm, "%s: interface not found!\n", __func__); goto out_free;