From: Satyam Sharma msr_class_cpu_callback() can be marked __cpuinit, being the notifier callback for a __cpuinitdata notifier_block. So can be marked msr_device_create() too, called only from the newly-__cpuinit msr_class_cpu_callback() or from __init-marked msr_init(). Signed-off-by: Satyam Sharma Cc: Andi Kleen Acked-by: H. Peter Anvin Signed-off-by: Andrew Morton --- arch/i386/kernel/msr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/kernel/msr.c~x86-msr-driver-misc-cpuinit-annotations arch/i386/kernel/msr.c --- a/arch/i386/kernel/msr.c~x86-msr-driver-misc-cpuinit-annotations +++ a/arch/i386/kernel/msr.c @@ -135,7 +135,7 @@ static const struct file_operations msr_ .open = msr_open, }; -static int msr_device_create(int cpu) +static int __cpuinit msr_device_create(int cpu) { struct device *dev; _