From: Andrew Morton <akpm@linux-foundation.org>

ERROR: do not use assignment in if condition
#58: FILE: fs/ext3/resize.c:173:
+		if ((err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA)))

ERROR: use tabs not spaces
#60: FILE: fs/ext3/resize.c:175:
+^I$

ERROR: do not use assignment in if condition
#60: FILE: fs/ext3/resize.c:175:
+	        if ((err = ext3_journal_get_write_access(handle, bh)))

ERROR: use tabs not spaces
#62: FILE: fs/ext3/resize.c:177:
$

ERROR: do not use assignment in if condition
#87: FILE: fs/ext3/resize.c:233:
+		if ((err = extend_or_restart_transaction(handle, 1, bh)))

ERROR: do not use assignment in if condition
#97: FILE: fs/ext3/resize.c:261:
+		if ((err = extend_or_restart_transaction(handle, 1, bh)))

ERROR: do not use assignment in if condition
#108: FILE: fs/ext3/resize.c:286:
+		if ((err = extend_or_restart_transaction(handle, 1, bh)))

ERROR: do not use assignment in if condition
#119: FILE: fs/ext3/resize.c:298:
+	if ((err = extend_or_restart_transaction(handle, 2, bh)))

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Cc: <linux-ext4@vger.kernel.org>
Cc: Andreas Dilger <adilger@clusterfs.com>
Cc: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


diff -puN fs/ext3/resize.c~ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes fs/ext3/resize.c
--- a/fs/ext3/resize.c~ext3-lighten-up-resize-transaction-requirements-checkpatch-fixes
+++ a/fs/ext3/resize.c
@@ -170,11 +170,13 @@ static int extend_or_restart_transaction
 	if (err < 0)
 		return err;
 	if (err) {
-		if ((err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA)))
+		err = ext3_journal_restart(handle, EXT3_MAX_TRANS_DATA);
+		if (err)
 			return err;
-	        if ((err = ext3_journal_get_write_access(handle, bh)))
+		err = ext3_journal_get_write_access(handle, bh);
+		if (err)
 			return err;
-        }
+	}
 
 	return 0;
 }
@@ -230,7 +232,8 @@ static int setup_new_group_blocks(struct
 
 		ext3_debug("update backup group %#04lx (+%d)\n", block, bit);
 
-		if ((err = extend_or_restart_transaction(handle, 1, bh)))
+		err = extend_or_restart_transaction(handle, 1, bh);
+		if (err)
 			goto exit_bh;
 
 		gdb = sb_getblk(sb, block);
@@ -258,7 +261,8 @@ static int setup_new_group_blocks(struct
 
 		ext3_debug("clear reserved block %#04lx (+%d)\n", block, bit);
 
-		if ((err = extend_or_restart_transaction(handle, 1, bh)))
+		err = extend_or_restart_transaction(handle, 1, bh);
+		if (err)
 			goto exit_bh;
 
 		if (IS_ERR(gdb = bclean(handle, sb, block))) {
@@ -283,7 +287,8 @@ static int setup_new_group_blocks(struct
 
 		ext3_debug("clear inode block %#04lx (+%d)\n", block, bit);
 
-		if ((err = extend_or_restart_transaction(handle, 1, bh)))
+		err = extend_or_restart_transaction(handle, 1, bh);
+		if (err)
 			goto exit_bh;
 
 		if (IS_ERR(it = bclean(handle, sb, block))) {
@@ -295,7 +300,8 @@ static int setup_new_group_blocks(struct
 		ext3_set_bit(bit, bh->b_data);
 	}
 
-	if ((err = extend_or_restart_transaction(handle, 2, bh)))
+	err = extend_or_restart_transaction(handle, 2, bh);
+	if (err)
 		goto exit_bh;
 
 	mark_bitmap_end(input->blocks_count, EXT3_BLOCKS_PER_GROUP(sb),
_