From: Andrew Morton WARNING: line over 80 characters #47: FILE: drivers/net/forcedeth.c:4983: + mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) | BMCR_PDOWN); Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Cc: Ayaz Abdulla Cc: Ed Swierk Cc: Jeff Garzik Signed-off-by: Andrew Morton --- diff -puN drivers/net/forcedeth.c~forcedeth-power-down-phy-when-interface-is-down-checkpatch-fixes drivers/net/forcedeth.c --- a/drivers/net/forcedeth.c~forcedeth-power-down-phy-when-interface-is-down-checkpatch-fixes +++ a/drivers/net/forcedeth.c @@ -4980,7 +4980,7 @@ static int nv_close(struct net_device *d } else { /* power down phy */ mii_rw(dev, np->phyaddr, MII_BMCR, - mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) | BMCR_PDOWN); + mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ)|BMCR_PDOWN); } /* FIXME: power down nic */ _