From: Adrian Bunk The Coverity checker spotted that we'd have already oops'ed if "tty" was NULL. Since "tty" can't be NULL when we reach this line of code this patch removes the NULL check. Signed-off-by: Adrian Bunk Acked-by: Alan Cox Signed-off-by: Andrew Morton --- drivers/char/n_hdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/char/n_hdlc.c~n_hdlcc-fix-check-after-use drivers/char/n_hdlc.c --- a/drivers/char/n_hdlc.c~n_hdlcc-fix-check-after-use +++ a/drivers/char/n_hdlc.c @@ -229,7 +229,7 @@ static void n_hdlc_release(struct n_hdlc wake_up_interruptible (&tty->read_wait); wake_up_interruptible (&tty->write_wait); - if (tty != NULL && tty->disc_data == n_hdlc) + if (tty->disc_data == n_hdlc) tty->disc_data = NULL; /* Break the tty->n_hdlc link */ /* Release transmit and receive buffers */ _