From: Ralf Baechle assumes that struct tty_struct has previously been included. If not, this pile of warnings will result: CC [M] drivers/video/console/newport_con.o In file included from drivers/video/console/newport_con.c:18: include/linux/selection.h:16: warning: 'struct tty_struct' declared inside param eter list include/linux/selection.h:16: warning: its scope is only this definition or decl aration, which is probably not what you want include/linux/selection.h:17: warning: 'struct tty_struct' declared inside param eter list include/linux/selection.h:20: warning: 'struct tty_struct' declared inside param eter list Fixed by adding a forward declaration of struct tty_struct. Signed-off-by: Ralf Baechle Signed-off-by: Antonino Daplas Signed-off-by: Andrew Morton --- include/linux/selection.h | 1 + 1 files changed, 1 insertion(+) diff -puN include/linux/selection.h~vt-fix-warnings-in-selectionh include/linux/selection.h --- a/include/linux/selection.h~vt-fix-warnings-in-selectionh +++ a/include/linux/selection.h @@ -13,6 +13,7 @@ struct tty_struct; extern struct vc_data *sel_cons; +struct tty_struct; extern void clear_selection(void); extern int set_selection(const struct tiocl_selection __user *sel, struct tty_struct *tty); _