From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #30: FILE: include/asm-ia64/bitops.h:131: +__clear_bit_unlock (int nr, volatile void *addr) WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #30: FILE: include/asm-ia64/bitops.h:131: +__clear_bit_unlock (int nr, volatile void *addr) WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #33: FILE: include/asm-ia64/bitops.h:134: + volatile __u32 *m; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #35: FILE: include/asm-ia64/bitops.h:136: + m = (volatile __u32 *) addr + (nr >> 5); total: 0 errors, 4 warnings, 24 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Luck, Tony" Cc: Christoph Lameter Cc: Nick Piggin Signed-off-by: Andrew Morton --- include/asm-ia64/bitops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN include/asm-ia64/bitops.h~ia64-slim-down-__clear_bit_unlock-checkpatch-fixes include/asm-ia64/bitops.h --- a/include/asm-ia64/bitops.h~ia64-slim-down-__clear_bit_unlock-checkpatch-fixes +++ a/include/asm-ia64/bitops.h @@ -128,12 +128,12 @@ clear_bit_unlock (int nr, volatile void * with release semantics. See also __raw_spin_unlock(). */ static __inline__ void -__clear_bit_unlock (int nr, volatile void *addr) +__clear_bit_unlock(int nr, volatile void *addr) { __u32 mask, new; volatile __u32 *m; - m = (volatile __u32 *) addr + (nr >> 5); + m = (volatile __u32 *)addr + (nr >> 5); mask = ~(1 << (nr & 31)); new = *m & mask; barrier(); _