From: Andrew Morton ERROR: use tabs not spaces #50: FILE: drivers/scsi/ips.c:2084: + if (ha->nvram->bios_low[3] == 0) {$ ERROR: use tabs not spaces #60: FILE: drivers/scsi/ips.c:2785: + if ((scb->scsi_cmd->cmnd[0] == WRITE_BUFFER) && (scb->data_len == 0))$ ERROR: use tabs not spaces #61: FILE: drivers/scsi/ips.c:2786: + scb->dcdb.cmd_attribute = 0;$ ERROR: use tabs not spaces #116: FILE: drivers/scsi/ips.c:4723: +^I done = ips_poll_for_flush_complete(ha);$ ERROR: no space before that close parenthesis ')' #135: FILE: drivers/scsi/ips.c:4760: + if (cstatus.fields.command_id == IPS_MAX_CMDS ) WARNING: do not add new typedefs #195: FILE: drivers/scsi/ips.h:555: +typedef struct WARNING: do not add new typedefs #213: FILE: drivers/scsi/ips.h:793: +typedef struct total: 5 errors, 2 warnings, 181 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: James Bottomley Cc: Jeff Garzik Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/scsi/ips.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff -puN drivers/scsi/ips.c~ips-trim-trailing-whitespace-checkpatch-fixes drivers/scsi/ips.c --- a/drivers/scsi/ips.c~ips-trim-trailing-whitespace-checkpatch-fixes +++ a/drivers/scsi/ips.c @@ -2081,7 +2081,7 @@ ips_host_info(ips_ha_t * ha, char *ptr, /* That keeps everything happy for "text" operations on the proc file. */ if (le32_to_cpu(ha->nvram->signature) == IPS_NVRAM_P5_SIG) { - if (ha->nvram->bios_low[3] == 0) { + if (ha->nvram->bios_low[3] == 0) { copy_info(&info, "\tBIOS Version : %c%c%c%c%c%c%c\n", ha->nvram->bios_high[0], ha->nvram->bios_high[1], @@ -2780,10 +2780,11 @@ ips_next(ips_ha_t * ha, int intr) scb->dcdb.cmd_attribute = ips_command_direction[scb->scsi_cmd->cmnd[0]]; - /* Allow a WRITE BUFFER Command to Have no Data */ - /* This is Used by Tape Flash Utilites */ - if ((scb->scsi_cmd->cmnd[0] == WRITE_BUFFER) && (scb->data_len == 0)) - scb->dcdb.cmd_attribute = 0; + /* Allow a WRITE BUFFER Command to Have no Data */ + /* This is Used by Tape Flash Utilites */ + if ((scb->scsi_cmd->cmnd[0] == WRITE_BUFFER) && + (scb->data_len == 0)) + scb->dcdb.cmd_attribute = 0; if (!(scb->dcdb.cmd_attribute & 0x3)) scb->dcdb.transfer_length = 0; @@ -4720,7 +4721,7 @@ ips_flush_and_reset(ips_ha_t *ha) done = 0; while ((time > 0) && (!done)) { - done = ips_poll_for_flush_complete(ha); + done = ips_poll_for_flush_complete(ha); /* This may look evil, but it's only done during extremely rare start-up conditions ! */ udelay(1000); time--; @@ -4757,7 +4758,7 @@ ips_poll_for_flush_complete(ips_ha_t * h break; /* Success is when we see the Flush Command ID */ - if (cstatus.fields.command_id == IPS_MAX_CMDS ) + if (cstatus.fields.command_id == IPS_MAX_CMDS) return 1; } _