From: Diego Woitasen sys_pciconfig_{read,write}() are protected against PCI removal with the reference count in struct pci_dev. The concurrency of pci_user_{read,write}_config_* functions are already protected by pci_lock in drivers/pci/access.c. Signed-off-by: Diego Woitasen Cc: Greg KH Signed-off-by: Andrew Morton --- drivers/pci/syscall.c | 5 ----- 1 file changed, 5 deletions(-) diff -puN drivers/pci/syscall.c~pci-remove-unneeded-lock_kernel-in-drivers-pci-syscallc drivers/pci/syscall.c --- a/drivers/pci/syscall.c~pci-remove-unneeded-lock_kernel-in-drivers-pci-syscallc +++ a/drivers/pci/syscall.c @@ -34,7 +34,6 @@ sys_pciconfig_read(unsigned long bus, un if (!dev) goto error; - lock_kernel(); switch (len) { case 1: cfg_ret = pci_user_read_config_byte(dev, off, &byte); @@ -47,10 +46,8 @@ sys_pciconfig_read(unsigned long bus, un break; default: err = -EINVAL; - unlock_kernel(); goto error; }; - unlock_kernel(); err = -EIO; if (cfg_ret != PCIBIOS_SUCCESSFUL) @@ -107,7 +104,6 @@ sys_pciconfig_write(unsigned long bus, u if (!dev) return -ENODEV; - lock_kernel(); switch(len) { case 1: err = get_user(byte, (u8 __user *)buf); @@ -140,7 +136,6 @@ sys_pciconfig_write(unsigned long bus, u err = -EINVAL; break; } - unlock_kernel(); pci_dev_put(dev); return err; } _