From: Andrew Morton ERROR: need consistent spacing around '*' (ctx:WxV) #23: FILE: drivers/scsi/gdth.c:144: +static irqreturn_t __gdth_interrupt(gdth_ha_str *ha, ^ ERROR: need consistent spacing around '*' (ctx:WxV) #40: FILE: drivers/scsi/gdth.c:1336: +static unchar gdth_get_status(gdth_ha_str *ha) ^ ERROR: use tabs not spaces #57: FILE: drivers/scsi/gdth.c:1523: + __gdth_interrupt(ha, true, &wait_index);$ ERROR: need consistent spacing around '*' (ctx:WxV) #66: FILE: drivers/scsi/gdth.c:3036: +static irqreturn_t __gdth_interrupt(gdth_ha_str *ha, ^ ERROR: do not use assignment in if condition #84: FILE: drivers/scsi/gdth.c:3067: + if (0 == (IStatus = gdth_get_status(ha))) { total: 5 errors, 0 warnings, 74 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Boaz Harrosh Cc: James Bottomley Cc: Jeff Garzik Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/scsi/gdth.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -puN drivers/scsi/gdth.c~scsi-gdth-kill-unneeded-irq-argument-checkpatch-fixes drivers/scsi/gdth.c --- a/drivers/scsi/gdth.c~scsi-gdth-kill-unneeded-irq-argument-checkpatch-fixes +++ a/drivers/scsi/gdth.c @@ -1520,7 +1520,7 @@ static int gdth_wait(gdth_ha_str *ha, in return 1; /* no wait required */ do { - __gdth_interrupt(ha, true, &wait_index); + __gdth_interrupt(ha, true, &wait_index); if (wait_index == index) { answer_found = TRUE; break; @@ -3064,7 +3064,8 @@ static irqreturn_t __gdth_interrupt(gdth spin_lock_irqsave(&ha->smp_lock, flags); /* search controller */ - if (0 == (IStatus = gdth_get_status(ha))) { + IStatus = gdth_get_status(ha); + if (IStatus == 0) { /* spurious interrupt */ if (!gdth_polling) spin_unlock_irqrestore(&ha->smp_lock, flags); _