From: Andrew Morton ERROR: need a space before the open parenthesis '(' #35: FILE: sound/oss/pss.c:678: + else if(check_region(pss_cdrom_port, 2)) { ERROR: else should follow close brace '}' #35: FILE: sound/oss/pss.c:678: } + else if(check_region(pss_cdrom_port, 2)) { WARNING: braces {} are not necessary for single statement blocks #35: FILE: sound/oss/pss.c:678: + else if(check_region(pss_cdrom_port, 2)) { printk(KERN_ERR "PSS: CDROM I/O port conflict.\n"); } ERROR: else should follow close brace '}' #44: FILE: sound/oss/pss.c:681: } + else { total: 3 errors, 1 warnings, 56 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jeff Garzik Cc: Jeff Garzik Signed-off-by: Andrew Morton --- sound/oss/pss.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff -puN sound/oss/pss.c~sound-oss-pss-set_io_base-always-returns-success-mark-it-void-checkpatch-fixes sound/oss/pss.c --- a/sound/oss/pss.c~sound-oss-pss-set_io_base-always-returns-success-mark-it-void-checkpatch-fixes +++ a/sound/oss/pss.c @@ -671,14 +671,11 @@ static void configure_nonsound_component /* Configure CDROM port */ - if(pss_cdrom_port == -1) /* If cdrom port enablation wasn't requested */ - { + if (pss_cdrom_port == -1) { /* If cdrom port enablation wasn't requested */ printk(KERN_INFO "PSS: CDROM port not enabled.\n"); - } - else if(check_region(pss_cdrom_port, 2)) { + } else if (check_region(pss_cdrom_port, 2)) { printk(KERN_ERR "PSS: CDROM I/O port conflict.\n"); - } - else { + } else { set_io_base(devc, CONF_CDROM, pss_cdrom_port); printk(KERN_INFO "PSS: CDROM I/O port set to 0x%x.\n", pss_cdrom_port); } _