From: Andrew Morton WARNING: externs should be avoided in .c files #724: FILE: fs/binfmt_elf.c:514: +extern unsigned long load_aout_interp(struct exec *interp_ex, ERROR: "foo * bar" should be "foo *bar" #875: FILE: include/asm-alpha/a.out-core.h:26: + struct switch_stack * sw = ((struct switch_stack *) pt) - 1; WARNING: line over 80 characters #997: FILE: include/asm-arm/a.out-core.h:32: + dump->u_dsize = (tsk->mm->brk - tsk->mm->start_data + PAGE_SIZE - 1) >> PAGE_SHIFT; WARNING: no space between function name and open parenthesis '(' #1010: FILE: include/asm-arm/a.out-core.h:45: + dump->u_fpvalid = dump_fpu (regs, &dump->u_fp); WARNING: line over 80 characters #1262: FILE: include/asm-m68k/a.out-core.h:38: + dump->u_ssize = ((unsigned long) (TASK_SIZE - dump->start_stack)) >> PAGE_SHIFT; WARNING: no space between function name and open parenthesis '(' #1287: FILE: include/asm-m68k/a.out-core.h:63: + dump->u_fpvalid = dump_fpu (regs, &dump->m68kfp); WARNING: line over 80 characters #1583: FILE: include/asm-sparc/a.out-core.h:33: + memcpy(&dump->regs.regs[0], ®s->u_regs[1], (sizeof(unsigned long) * 15)); WARNING: line over 80 characters #1592: FILE: include/asm-sparc/a.out-core.h:42: + memcpy(&dump->fpu.fpstatus.fregs.regs[0], ¤t->thread.float_regs[0], (sizeof(unsigned long) * 32)); WARNING: line over 80 characters #1865: FILE: include/asm-x86/a.out-core.h:33: + dump->u_dsize = ((unsigned long) (current->mm->brk + (PAGE_SIZE-1))) >> PAGE_SHIFT; WARNING: line over 80 characters #1872: FILE: include/asm-x86/a.out-core.h:40: + dump->u_ssize = ((unsigned long) (TASK_SIZE - dump->start_stack)) >> PAGE_SHIFT; ERROR: need space after that ',' (ctx:VxV) #1884: FILE: include/asm-x86/a.out-core.h:52: + savesegment(gs,dump->regs.gs); ^ WARNING: no space between function name and open parenthesis '(' #1892: FILE: include/asm-x86/a.out-core.h:60: + dump->u_fpvalid = dump_fpu (regs, &dump->i387); total: 2 errors, 10 warnings, 1565 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Howells Signed-off-by: Andrew Morton --- include/asm-alpha/a.out-core.h | 2 +- include/asm-arm/a.out-core.h | 2 +- include/asm-m68k/a.out-core.h | 2 +- include/asm-sparc/a.out-core.h | 7 +++++-- include/asm-x86/a.out-core.h | 4 ++-- 5 files changed, 10 insertions(+), 7 deletions(-) diff -puN include/asm-alpha/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes include/asm-alpha/a.out-core.h --- a/include/asm-alpha/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes +++ a/include/asm-alpha/a.out-core.h @@ -23,7 +23,7 @@ static inline void aout_dump_thread(struct pt_regs *pt, struct user *dump) { /* switch stack follows right below pt_regs: */ - struct switch_stack * sw = ((struct switch_stack *) pt) - 1; + struct switch_stack *sw = ((struct switch_stack *)pt) - 1; dump->magic = CMAGIC; dump->start_code = current->mm->start_code; diff -puN include/asm-arm/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes include/asm-arm/a.out-core.h --- a/include/asm-arm/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes +++ a/include/asm-arm/a.out-core.h @@ -42,7 +42,7 @@ static inline void aout_dump_thread(stru dump->u_ssize = (0x04000000 - dump->start_stack) >> PAGE_SHIFT; dump->regs = *regs; - dump->u_fpvalid = dump_fpu (regs, &dump->u_fp); + dump->u_fpvalid = dump_fpu(regs, &dump->u_fp); } #endif /* __KERNEL__ */ diff -puN include/asm-m68k/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes include/asm-m68k/a.out-core.h --- a/include/asm-m68k/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes +++ a/include/asm-m68k/a.out-core.h @@ -60,7 +60,7 @@ static inline void aout_dump_thread(stru dump->regs.pc = regs->pc; dump->regs.fmtvec = (regs->format << 12) | regs->vector; /* dump floating point stuff */ - dump->u_fpvalid = dump_fpu (regs, &dump->m68kfp); + dump->u_fpvalid = dump_fpu(regs, &dump->m68kfp); } #endif /* __KERNEL__ */ diff -puN include/asm-sparc/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes include/asm-sparc/a.out-core.h --- a/include/asm-sparc/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes +++ a/include/asm-sparc/a.out-core.h @@ -30,7 +30,8 @@ static inline void aout_dump_thread(stru dump->regs.npc = regs->npc; dump->regs.y = regs->y; /* fuck me plenty */ - memcpy(&dump->regs.regs[0], ®s->u_regs[1], (sizeof(unsigned long) * 15)); + memcpy(&dump->regs.regs[0], ®s->u_regs[1], + (sizeof(unsigned long) * 15)); dump->uexec = current->thread.core_exec; dump->u_tsize = (((unsigned long) current->mm->end_code) - ((unsigned long) current->mm->start_code)) & ~(PAGE_SIZE - 1); @@ -39,7 +40,9 @@ static inline void aout_dump_thread(stru dump->u_dsize &= ~(PAGE_SIZE - 1); first_stack_page = (regs->u_regs[UREG_FP] & ~(PAGE_SIZE - 1)); dump->u_ssize = (TASK_SIZE - first_stack_page) & ~(PAGE_SIZE - 1); - memcpy(&dump->fpu.fpstatus.fregs.regs[0], ¤t->thread.float_regs[0], (sizeof(unsigned long) * 32)); + memcpy(&dump->fpu.fpstatus.fregs.regs[0], + ¤t->thread.float_regs[0], + sizeof(unsigned long) * 32); dump->fpu.fpstatus.fsr = current->thread.fsr; dump->fpu.fpstatus.flags = dump->fpu.fpstatus.extra = 0; dump->fpu.fpstatus.fpq_count = current->thread.fpqdepth; diff -puN include/asm-x86/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes include/asm-x86/a.out-core.h --- a/include/asm-x86/a.out-core.h~suppress-aout-library-support-if-config_binfmt_aout-checkpatch-fixes +++ a/include/asm-x86/a.out-core.h @@ -49,7 +49,7 @@ static inline void aout_dump_thread(stru dump->regs.ds = regs->xds; dump->regs.es = regs->xes; dump->regs.fs = regs->xfs; - savesegment(gs,dump->regs.gs); + savesegment(gs, dump->regs.gs); dump->regs.orig_eax = regs->orig_eax; dump->regs.eip = regs->eip; dump->regs.cs = regs->xcs; @@ -57,7 +57,7 @@ static inline void aout_dump_thread(stru dump->regs.esp = regs->esp; dump->regs.ss = regs->xss; - dump->u_fpvalid = dump_fpu (regs, &dump->i387); + dump->u_fpvalid = dump_fpu(regs, &dump->i387); } #endif /* CONFIG_X86_32 */ _