From: Andrew Morton no no no no. Please add checkpatch.pl to your workflow. Cc: Badari Pulavarty Cc: Greg KH Signed-off-by: Andrew Morton --- arch/powerpc/kernel/vio.c | 2 -- drivers/base/base.h | 2 -- include/linux/device.h | 1 + 3 files changed, 1 insertion(+), 4 deletions(-) diff -puN arch/powerpc/kernel/vio.c~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix arch/powerpc/kernel/vio.c --- a/arch/powerpc/kernel/vio.c~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix +++ a/arch/powerpc/kernel/vio.c @@ -37,8 +37,6 @@ #include #include -extern struct kset *devices_kset; /* needed for vio_find_name() */ - static struct bus_type vio_bus_type; static struct vio_dev vio_bus_device = { /* fake "parent" device */ diff -puN drivers/base/base.h~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix drivers/base/base.h --- a/drivers/base/base.h~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix +++ a/drivers/base/base.h @@ -71,5 +71,3 @@ struct class_device_attribute *to_class_ extern char *make_class_name(const char *name, struct kobject *kobj); extern int devres_release_all(struct device *dev); - -extern struct kset *devices_kset; diff -puN include/linux/device.h~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix include/linux/device.h --- a/include/linux/device.h~unbork-gregkh-driver-kset-convert-sys-devices-to-use-kset_create-vioc-fix +++ a/include/linux/device.h @@ -109,6 +109,7 @@ extern int bus_unregister_notifier(struc #define BUS_NOTIFY_UNBIND_DRIVER 0x00000004 /* driver about to be unbound */ +extern struct kset *devices_kset; extern struct kset *bus_get_kset(struct bus_type *bus); extern struct klist *bus_get_device_klist(struct bus_type *bus); _