From: Andrew Morton ERROR: use tabs not spaces #146: FILE: drivers/isdn/act2000/module.c:527: + if (!(card->flags & ACT2000_FLAGS_RUNNING))$ ERROR: use tabs not spaces #155: FILE: drivers/isdn/act2000/module.c:542: + if (!(card->flags & ACT2000_FLAGS_RUNNING))$ ERROR: use tabs not spaces #164: FILE: drivers/isdn/act2000/module.c:557: + if (!(card->flags & ACT2000_FLAGS_RUNNING))$ ERROR: need a space before the open parenthesis '(' #377: FILE: drivers/net/wireless/airo.c:6410: + if(!(dwrq->flags & IW_ENCODE_MODE)) { WARNING: braces {} are not necessary for single statement blocks #377: FILE: drivers/net/wireless/airo.c:6410: + if(!(dwrq->flags & IW_ENCODE_MODE)) { return -EINVAL; } WARNING: braces {} are not necessary for single statement blocks #389: FILE: drivers/net/wireless/atmel.c:1762: + if (!(dwrq->flags & IW_ENCODE_MODE)) { return -EINVAL; } ERROR: need a space before the open parenthesis '(' #446: FILE: drivers/video/sis/sis_main.c:430: + if(!(buffer[0x14] & 0x80)) { total: 5 errors, 2 warnings, 346 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Antonino A. Daplas" Cc: "David S. Miller" Cc: "John W. Linville" Cc: Al Viro Cc: Alexey Dobriyan Cc: Jeff Garzik Cc: Jens Axboe Cc: Karsten Keil Cc: Mark Fasheh Cc: Mauro Carvalho Chehab Cc: Peter Osterlund Signed-off-by: Andrew Morton --- drivers/isdn/act2000/module.c | 6 +++--- drivers/net/wireless/airo.c | 3 +-- drivers/net/wireless/atmel.c | 3 +-- drivers/video/sis/sis_main.c | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff -puN drivers/isdn/act2000/module.c~fix-versus-precedence-in-various-places-checkpatch-fixes drivers/isdn/act2000/module.c --- a/drivers/isdn/act2000/module.c~fix-versus-precedence-in-various-places-checkpatch-fixes +++ a/drivers/isdn/act2000/module.c @@ -524,7 +524,7 @@ if_writecmd(const u_char __user *buf, in act2000_card *card = act2000_findcard(id); if (card) { - if (!(card->flags & ACT2000_FLAGS_RUNNING)) + if (!(card->flags & ACT2000_FLAGS_RUNNING)) return -ENODEV; return (len); } @@ -539,7 +539,7 @@ if_readstatus(u_char __user * buf, int l act2000_card *card = act2000_findcard(id); if (card) { - if (!(card->flags & ACT2000_FLAGS_RUNNING)) + if (!(card->flags & ACT2000_FLAGS_RUNNING)) return -ENODEV; return (act2000_readstatus(buf, len, card)); } @@ -554,7 +554,7 @@ if_sendbuf(int id, int channel, int ack, act2000_card *card = act2000_findcard(id); if (card) { - if (!(card->flags & ACT2000_FLAGS_RUNNING)) + if (!(card->flags & ACT2000_FLAGS_RUNNING)) return -ENODEV; return (act2000_sendbuf(card, channel, ack, skb)); } diff -puN drivers/net/wireless/airo.c~fix-versus-precedence-in-various-places-checkpatch-fixes drivers/net/wireless/airo.c --- a/drivers/net/wireless/airo.c~fix-versus-precedence-in-various-places-checkpatch-fixes +++ a/drivers/net/wireless/airo.c @@ -6408,9 +6408,8 @@ static int airo_set_encode(struct net_de set_wep_key(local, index, NULL, 0, perm, 1); } else /* Don't complain if only change the mode */ - if(!(dwrq->flags & IW_ENCODE_MODE)) { + if (!(dwrq->flags & IW_ENCODE_MODE)) return -EINVAL; - } } /* Read the flags */ if(dwrq->flags & IW_ENCODE_DISABLED) diff -puN drivers/net/wireless/atmel.c~fix-versus-precedence-in-various-places-checkpatch-fixes drivers/net/wireless/atmel.c --- a/drivers/net/wireless/atmel.c~fix-versus-precedence-in-various-places-checkpatch-fixes +++ a/drivers/net/wireless/atmel.c @@ -1759,9 +1759,8 @@ static int atmel_set_encode(struct net_d priv->default_key = index; } else /* Don't complain if only change the mode */ - if (!(dwrq->flags & IW_ENCODE_MODE)) { + if (!(dwrq->flags & IW_ENCODE_MODE)) return -EINVAL; - } } /* Read the flags */ if (dwrq->flags & IW_ENCODE_DISABLED) { diff -puN drivers/video/sis/sis_main.c~fix-versus-precedence-in-various-places-checkpatch-fixes drivers/video/sis/sis_main.c --- a/drivers/video/sis/sis_main.c~fix-versus-precedence-in-various-places-checkpatch-fixes +++ a/drivers/video/sis/sis_main.c @@ -427,7 +427,7 @@ sisfb_interpret_edid(struct sisfb_monito monitor->feature = buffer[0x18]; - if(!(buffer[0x14] & 0x80)) { + if (!(buffer[0x14] & 0x80)) { if(!(buffer[0x14] & 0x08)) { printk(KERN_INFO "sisfb: WARNING: Monitor does not support separate syncs\n"); _