From stern@rowland.harvard.edu Wed Oct 10 13:29:09 2007 From: Mauro Carvalho Chehab Date: Wed, 10 Oct 2007 16:29:02 -0400 (EDT) Subject: usb-storage: always set the allow_restart flag To: Greg KH , Matthew Dharm Cc: Mauro Carvalho Chehab , USB Storage list Message-ID: From: Mauro Carvalho Chehab This patch (as1000) sets the SCSI allow_restart flag for USB disk devices. In theory this should never hurt, and there definitely are devices out there (such as the Seagate 250-GB external drive) which need the flag to be set. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/scsiglue.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@ -177,6 +177,10 @@ static int slave_configure(struct scsi_d * is an occasional series of retries that will all fail. */ sdev->retry_hwerror = 1; + /* USB disks should allow restart. Some drives spin down + * automatically, requiring a START-STOP UNIT command. */ + sdev->allow_restart = 1; + } else { /* Non-disk-type devices don't need to blacklist any pages