From: Andrew Morton WARNING: line over 80 characters #88: FILE: fs/proc/inode.c:427: + &proc_reg_file_ops_no_compat; WARNING: line over 80 characters #92: FILE: fs/proc/inode.c:430: + inode->i_fop = &proc_reg_file_ops; ERROR: else should follow close brace '}' #94: FILE: fs/proc/inode.c:432: + } + else total: 1 errors, 2 warnings, 85 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Eric W. Biederman" Cc: David Howells Signed-off-by: Andrew Morton --- fs/proc/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/proc/inode.c~iget-stop-procfs-from-using-iget-and-read_inode-checkpatch-fixes fs/proc/inode.c --- a/fs/proc/inode.c~iget-stop-procfs-from-using-iget-and-read_inode-checkpatch-fixes +++ a/fs/proc/inode.c @@ -428,9 +428,9 @@ struct inode *proc_get_inode(struct supe else #endif inode->i_fop = &proc_reg_file_ops; - } - else + } else { inode->i_fop = de->proc_fops; + } } } unlock_new_inode(inode); _