From: Andrew Morton ERROR: "foo * bar" should be "foo *bar" #85: FILE: fs/minix/inode.c:415: +static struct inode *V1_minix_iget(struct inode * inode) ERROR: "foo * bar" should be "foo *bar" #112: FILE: fs/minix/inode.c:448: +static struct inode *V2_minix_iget(struct inode * inode) ERROR: use tabs not spaces #181: FILE: fs/minix/namei.c:58: + ^I^Iif (IS_ERR(inode))$ total: 3 errors, 0 warnings, 144 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Howells Signed-off-by: Andrew Morton --- fs/minix/inode.c | 4 ++-- fs/minix/namei.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff -puN fs/minix/inode.c~iget-stop-the-minix-filesystem-from-using-iget-and-checkpatch-fixes fs/minix/inode.c --- a/fs/minix/inode.c~iget-stop-the-minix-filesystem-from-using-iget-and-checkpatch-fixes +++ a/fs/minix/inode.c @@ -412,7 +412,7 @@ void minix_set_inode(struct inode *inode /* * The minix V1 function to read an inode. */ -static struct inode *V1_minix_iget(struct inode * inode) +static struct inode *V1_minix_iget(struct inode *inode) { struct buffer_head * bh; struct minix_inode * raw_inode; @@ -445,7 +445,7 @@ static struct inode *V1_minix_iget(struc /* * The minix V2 function to read an inode. */ -static struct inode *V2_minix_iget(struct inode * inode) +static struct inode *V2_minix_iget(struct inode *inode) { struct buffer_head * bh; struct minix2_inode * raw_inode; diff -puN fs/minix/namei.c~iget-stop-the-minix-filesystem-from-using-iget-and-checkpatch-fixes fs/minix/namei.c --- a/fs/minix/namei.c~iget-stop-the-minix-filesystem-from-using-iget-and-checkpatch-fixes +++ a/fs/minix/namei.c @@ -55,7 +55,7 @@ static struct dentry *minix_lookup(struc ino = minix_inode_by_name(dentry); if (ino) { inode = minix_iget(dir->i_sb, ino); - if (IS_ERR(inode)) + if (IS_ERR(inode)) return ERR_CAST(inode); } d_add(dentry, inode); _