From: Andrew Morton WARNING: line over 80 characters #872: FILE: arch/x86/kernel/setup_32.c:486: + reserve_bootmem(crash_base, crash_size, BOOTMEM_DEFAULT); WARNING: line over 80 characters #916: FILE: arch/x86/kernel/setup_32.c:562: + reserve_bootmem(ramdisk_image, ramdisk_size, BOOTMEM_DEFAULT); WARNING: line over 80 characters #1058: FILE: mm/bootmem.c:114: +static int __init reserve_bootmem_core(bootmem_data_t *bdata, unsigned long addr, total: 0 errors, 3 warnings, 833 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Bernhard Walle Signed-off-by: Andrew Morton --- arch/x86/kernel/setup_32.c | 6 ++++-- mm/bootmem.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff -puN arch/x86/kernel/setup_32.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes arch/x86/kernel/setup_32.c --- a/arch/x86/kernel/setup_32.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes +++ a/arch/x86/kernel/setup_32.c @@ -481,7 +481,8 @@ static void __init reserve_crashkernel(v (unsigned long)(total_mem >> 20)); crashk_res.start = crash_base; crashk_res.end = crash_base + crash_size - 1; - reserve_bootmem(crash_base, crash_size, BOOTMEM_DEFAULT); + reserve_bootmem(crash_base, crash_size, + BOOTMEM_DEFAULT); } else printk(KERN_INFO "crashkernel reservation failed - " "you have to specify a base address\n"); @@ -557,7 +558,8 @@ void __init setup_bootmem_allocator(void unsigned long end_of_lowmem = max_low_pfn << PAGE_SHIFT; if (ramdisk_end <= end_of_lowmem) { - reserve_bootmem(ramdisk_image, ramdisk_size, BOOTMEM_DEFAULT); + reserve_bootmem(ramdisk_image, ramdisk_size, + BOOTMEM_DEFAULT); initrd_start = ramdisk_image + PAGE_OFFSET; initrd_end = initrd_start+ramdisk_size; } else { diff -puN mm/bootmem.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes mm/bootmem.c --- a/mm/bootmem.c~introduce-flags-for-reserve_bootmem-checkpatch-fixes +++ a/mm/bootmem.c @@ -111,8 +111,8 @@ static unsigned long __init init_bootmem * might be used for boot-time allocations - or it might get added * to the free page pool later on. */ -static int __init reserve_bootmem_core(bootmem_data_t *bdata, unsigned long addr, - unsigned long size, int flags) +static int __init reserve_bootmem_core(bootmem_data_t *bdata, + unsigned long addr, unsigned long size, int flags) { unsigned long sidx, eidx; unsigned long i; _