From: Andrew Morton ERROR: do not use C99 // comments #332: FILE: drivers/spi/mcp23s08.c:283: + // FIXME check status... total: 1 errors, 0 warnings, 399 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Brownell Cc: David Brownell Cc: Florian Fainelli Cc: Haavard Skinnemoen Signed-off-by: Andrew Morton --- drivers/spi/mcp23s08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/spi/mcp23s08.c~mcp23s08-spi-gpio-expander-checkpatch-fixes drivers/spi/mcp23s08.c --- a/drivers/spi/mcp23s08.c~mcp23s08-spi-gpio-expander-checkpatch-fixes +++ a/drivers/spi/mcp23s08.c @@ -280,7 +280,7 @@ static int mcp23s08_probe(struct spi_dev memcpy(&tx[2], &mcp->cache[MCP_IPOL], sizeof(tx) - 2); status = spi_write_then_read(mcp->spi, tx, sizeof tx, NULL, 0); - // FIXME check status... + /* FIXME check status... */ } status = gpiochip_add(&mcp->chip); _