From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #142: FILE: drivers/scsi/mac_scsi.c:329: + free_irq (shpnt->irq, shpnt); WARNING: no space between function name and open parenthesis '(' #185: FILE: drivers/scsi/sun3_scsi.c:313: + free_irq (shpnt->irq, shpnt); WARNING: no space between function name and open parenthesis '(' #206: FILE: drivers/scsi/sun3_scsi_vme.c:282: + free_irq (shpnt->irq, shpnt); ERROR: use tabs not spaces #219: FILE: drivers/scsi/t128.c:263: +^I ^I^I instance)) {$ total: 1 errors, 3 warnings, 156 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: James Bottomley Cc: Jeff Garzik Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/scsi/mac_scsi.c | 2 +- drivers/scsi/sun3_scsi.c | 2 +- drivers/scsi/sun3_scsi_vme.c | 2 +- drivers/scsi/t128.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/scsi/mac_scsi.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes drivers/scsi/mac_scsi.c --- a/drivers/scsi/mac_scsi.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes +++ a/drivers/scsi/mac_scsi.c @@ -326,7 +326,7 @@ int macscsi_detect(struct scsi_host_temp int macscsi_release (struct Scsi_Host *shpnt) { if (shpnt->irq != SCSI_IRQ_NONE) - free_irq (shpnt->irq, shpnt); + free_irq(shpnt->irq, shpnt); NCR5380_exit(shpnt); return 0; diff -puN drivers/scsi/sun3_scsi.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes drivers/scsi/sun3_scsi.c --- a/drivers/scsi/sun3_scsi.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes +++ a/drivers/scsi/sun3_scsi.c @@ -310,7 +310,7 @@ int sun3scsi_detect(struct scsi_host_tem int sun3scsi_release (struct Scsi_Host *shpnt) { if (shpnt->irq != SCSI_IRQ_NONE) - free_irq (shpnt->irq, shpnt); + free_irq(shpnt->irq, shpnt); iounmap((void *)sun3_scsi_regp); diff -puN drivers/scsi/sun3_scsi_vme.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes drivers/scsi/sun3_scsi_vme.c --- a/drivers/scsi/sun3_scsi_vme.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes +++ a/drivers/scsi/sun3_scsi_vme.c @@ -279,7 +279,7 @@ static int sun3scsi_detect(struct scsi_h int sun3scsi_release (struct Scsi_Host *shpnt) { if (shpnt->irq != SCSI_IRQ_NONE) - free_irq (shpnt->irq, shpnt); + free_irq(shpnt->irq, shpnt); iounmap((void *)sun3_scsi_regp); diff -puN drivers/scsi/t128.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes drivers/scsi/t128.c --- a/drivers/scsi/t128.c~scsi-fix-bugs-and-canonicalize-ncr5380_intr-drivers-checkpatch-fixes +++ a/drivers/scsi/t128.c @@ -260,7 +260,7 @@ found: if (instance->irq != SCSI_IRQ_NONE) if (request_irq(instance->irq, t128_intr, IRQF_DISABLED, "t128", - instance)) { + instance)) { printk("scsi%d : IRQ%d not free, interrupts disabled\n", instance->host_no, instance->irq); instance->irq = SCSI_IRQ_NONE; _