From: Andrew Morton ERROR: need space after that ',' (ctx:VxV) #43: FILE: include/linux/audit.h:547: +#define audit_log_d_path(b,p,d) do { ; } while (0) ^ ERROR: need space after that ',' (ctx:VxV) #43: FILE: include/linux/audit.h:547: +#define audit_log_d_path(b,p,d) do { ; } while (0) ^ WARNING: line over 80 characters #182: FILE: security/selinux/avc.c:630: + struct path path = { .dentry = u->dentry, WARNING: line over 80 characters #183: FILE: security/selinux/avc.c:631: + .mnt = u->mnt }; total: 2 errors, 2 warnings, 258 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jan Blunck Signed-off-by: Andrew Morton --- include/linux/audit.h | 2 +- security/selinux/avc.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff -puN include/linux/audit.h~d_path-use-struct-path-in-struct-avc_audit_data-checkpatch-fixes include/linux/audit.h --- a/include/linux/audit.h~d_path-use-struct-path-in-struct-avc_audit_data-checkpatch-fixes +++ a/include/linux/audit.h @@ -546,7 +546,7 @@ extern int audit_enabled; #define audit_log_hex(a,b,l) do { ; } while (0) #define audit_log_untrustedstring(a,s) do { ; } while (0) #define audit_log_n_untrustedstring(a,n,s) do { ; } while (0) -#define audit_log_d_path(b,p,d) do { ; } while (0) +#define audit_log_d_path(b, p, d) do { ; } while (0) #define audit_enabled 0 #endif #endif diff -puN security/selinux/avc.c~d_path-use-struct-path-in-struct-avc_audit_data-checkpatch-fixes security/selinux/avc.c --- a/security/selinux/avc.c~d_path-use-struct-path-in-struct-avc_audit_data-checkpatch-fixes +++ a/security/selinux/avc.c @@ -627,8 +627,10 @@ void avc_audit(u32 ssid, u32 tsid, case AF_UNIX: u = unix_sk(sk); if (u->dentry) { - struct path path = { .dentry = u->dentry, - .mnt = u->mnt }; + struct path path = { + .dentry = u->dentry, + .mnt = u->mnt + }; audit_log_d_path(ab, "path=", &path); break; _