From: Andrew Morton ERROR: need space after that ',' (ctx:VxV) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ ERROR: need space after that ',' (ctx:VxV) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ ERROR: need space after that ',' (ctx:VxO) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ ERROR: need space before that '&' (ctx:OxV) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ ERROR: need space after that ',' (ctx:VxV) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ ERROR: need space after that ',' (ctx:VxV) #87: FILE: fs/namei.c:1769: + error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); ^ total: 6 errors, 0 warnings, 266 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Dave Hansen Signed-off-by: Andrew Morton --- fs/namei.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN fs/namei.c~kill-filp_open-checkpatch-fixes fs/namei.c --- a/fs/namei.c~kill-filp_open-checkpatch-fixes +++ a/fs/namei.c @@ -1766,7 +1766,8 @@ struct file *open_pathname(int dfd, cons /* * Create - we need to know the parent. */ - error = path_lookup_create(dfd,pathname,LOOKUP_PARENT,&nd,flag,mode); + error = path_lookup_create(dfd, pathname, LOOKUP_PARENT, &nd, + flag, mode); if (error) return ERR_PTR(error); _