From: Andrew Morton WARNING: line over 80 characters #55: FILE: include/asm-x86/pgtable_32.h:87: +#define PKMAP_BASE ( (FIXADDR_BOOT_START - PAGE_SIZE*(LAST_PKMAP + 1)) & PMD_MASK ) ERROR: no space after that open parenthesis '(' #55: FILE: include/asm-x86/pgtable_32.h:87: +#define PKMAP_BASE ( (FIXADDR_BOOT_START - PAGE_SIZE*(LAST_PKMAP + 1)) & PMD_MASK ) ERROR: no space before that close parenthesis ')' #55: FILE: include/asm-x86/pgtable_32.h:87: +#define PKMAP_BASE ( (FIXADDR_BOOT_START - PAGE_SIZE*(LAST_PKMAP + 1)) & PMD_MASK ) total: 2 errors, 1 warnings, 32 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Christoph Lameter Cc: Ingo Molnar Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- include/asm-x86/pgtable_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN include/asm-x86/pgtable_32.h~i386-resolve-dependency-of-asm-i386-pgtableh-on-highmemh-checkpatch-fixes include/asm-x86/pgtable_32.h --- a/include/asm-x86/pgtable_32.h~i386-resolve-dependency-of-asm-i386-pgtableh-on-highmemh-checkpatch-fixes +++ a/include/asm-x86/pgtable_32.h @@ -84,7 +84,7 @@ void paging_init(void); #define LAST_PKMAP 1024 #endif -#define PKMAP_BASE ( (FIXADDR_BOOT_START - PAGE_SIZE*(LAST_PKMAP + 1)) & PMD_MASK ) +#define PKMAP_BASE ((FIXADDR_BOOT_START - PAGE_SIZE*(LAST_PKMAP + 1)) & PMD_MASK) #ifdef CONFIG_HIGHMEM # define VMALLOC_END (PKMAP_BASE-2*PAGE_SIZE) _