From: Andrew Morton Fix checkpatch warnings: ERROR: do not use C99 // comments #72: FILE: scripts/kallsyms.c:516: + // sort by address first ERROR: do not use C99 // comments #78: FILE: scripts/kallsyms.c:522: + // sort by "weakness" type ERROR: do not use C99 // comments #84: FILE: scripts/kallsyms.c:528: + // sort by initial order, so that other symbols are left undisturbed total: 3 errors, 0 warnings, 61 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches And a few coding-style things which checkpatch missed. And fix up constificiation to remove typecasting. Cc: Mathieu Desnoyers Cc: Paulo Marques Cc: Sam Ravnborg Signed-off-by: Andrew Morton --- scripts/kallsyms.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff -puN scripts/kallsyms.c~kallsyms-should-prefer-non-weak-symbols-checkpatch-fixes scripts/kallsyms.c --- a/scripts/kallsyms.c~kallsyms-should-prefer-non-weak-symbols-checkpatch-fixes +++ a/scripts/kallsyms.c @@ -31,14 +31,13 @@ #define KSYM_NAME_LEN 128 - struct sym_entry { unsigned long long addr; - unsigned int len, start_pos; + unsigned int len; + unsigned int start_pos; unsigned char *sym; }; - static struct sym_entry *table; static unsigned int table_size, table_cnt; static unsigned long long _text, _stext, _etext, _sinittext, _einittext; @@ -504,28 +503,28 @@ static void optimize_token_table(void) optimize_result(); } - static int compare_symbols(const void *a, const void *b) { - struct sym_entry *sa, *sb; + const struct sym_entry *sa; + const struct sym_entry *sb; int wa, wb; - sa = (struct sym_entry *) a; - sb = (struct sym_entry *) b; + sa = a; + sb = b; - // sort by address first + /* sort by address first */ if (sa->addr > sb->addr) return 1; if (sa->addr < sb->addr) return -1; - // sort by "weakness" type + /* sort by "weakness" type */ wa = (sa->sym[0] == 'w') || (sa->sym[0] == 'W'); wb = (sb->sym[0] == 'w') || (sb->sym[0] == 'W'); if (wa != wb) return wa - wb; - // sort by initial order, so that other symbols are left undisturbed + /* sort by initial order, so that other symbols are left undisturbed */ return sa->start_pos - sb->start_pos; } _