From: Andrew Morton WARNING: line over 80 characters #132: FILE: arch/um/include/init.h:106: +#define __uml_init_setup __used __attribute__ ((__section__ (".uml.setup.init"))) WARNING: line over 80 characters #133: FILE: arch/um/include/init.h:107: +#define __uml_setup_help __used __attribute__ ((__section__ (".uml.help.init"))) WARNING: line over 80 characters #134: FILE: arch/um/include/init.h:108: +#define __uml_init_call __used __attribute__ ((__section__ (".uml.initcall.init"))) WARNING: line over 80 characters #135: FILE: arch/um/include/init.h:109: +#define __uml_postsetup_call __used __attribute__ ((__section__ (".uml.postsetup.init"))) WARNING: line over 80 characters #136: FILE: arch/um/include/init.h:110: +#define __uml_exit_call __used __attribute__ ((__section__ (".uml.exitcall.exit"))) ERROR: use tabs not spaces #163: FILE: drivers/rapidio/rio.h:34: + static struct rio_route_ops __rio_route_ops __used \$ WARNING: no space between function name and open parenthesis '(' #199: FILE: include/asm-ia64/gcc_intrin.h:27: +register unsigned long ia64_r13 asm ("r13") __used; WARNING: no space between function name and open parenthesis '(' #211: FILE: include/asm-sh/machvec.h:71: + __used __attribute__((__section__ (".machvec.init"))) WARNING: line over 80 characters #306: FILE: include/linux/init.h:65: +#define __exit __used __attribute__ ((__section__(".exit.text"))) __cold ERROR: need spaces around that '=' (ctx:VxV) #324: FILE: include/linux/init.h:146: + __used __attribute__((__section__(".con_initcall.init")))=fn ^ total: 2 errors, 8 warnings, 286 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Adrian Bunk Cc: David Rientjes Signed-off-by: Andrew Morton --- drivers/rapidio/rio.h | 2 +- include/asm-ia64/gcc_intrin.h | 2 +- include/asm-sh/machvec.h | 2 +- include/linux/init.h | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/rapidio/rio.h~remove-__attribute_used__-checkpatch-fixes drivers/rapidio/rio.h --- a/drivers/rapidio/rio.h~remove-__attribute_used__-checkpatch-fixes +++ a/drivers/rapidio/rio.h @@ -31,7 +31,7 @@ extern struct rio_route_ops __end_rio_ro /* Helpers internal to the RIO core code */ #define DECLARE_RIO_ROUTE_SECTION(section, vid, did, add_hook, get_hook) \ - static struct rio_route_ops __rio_route_ops __used \ + static struct rio_route_ops __rio_route_ops __used \ __attribute__((__section__(#section))) = { vid, did, add_hook, get_hook }; /** diff -puN include/asm-ia64/gcc_intrin.h~remove-__attribute_used__-checkpatch-fixes include/asm-ia64/gcc_intrin.h --- a/include/asm-ia64/gcc_intrin.h~remove-__attribute_used__-checkpatch-fixes +++ a/include/asm-ia64/gcc_intrin.h @@ -24,7 +24,7 @@ extern void ia64_bad_param_for_setreg (void); extern void ia64_bad_param_for_getreg (void); -register unsigned long ia64_r13 asm ("r13") __used; +register unsigned long ia64_r13 asm("r13") __used; #define ia64_setreg(regnum, val) \ ({ \ diff -puN include/asm-sh/machvec.h~remove-__attribute_used__-checkpatch-fixes include/asm-sh/machvec.h --- a/include/asm-sh/machvec.h~remove-__attribute_used__-checkpatch-fixes +++ a/include/asm-sh/machvec.h @@ -68,6 +68,6 @@ extern struct sh_machine_vector sh_mv; #define get_system_type() sh_mv.mv_name #define __initmv \ - __used __attribute__((__section__ (".machvec.init"))) + __used __attribute__((__section__(".machvec.init"))) #endif /* _ASM_SH_MACHVEC_H */ diff -puN include/linux/init.h~remove-__attribute_used__-checkpatch-fixes include/linux/init.h --- a/include/linux/init.h~remove-__attribute_used__-checkpatch-fixes +++ a/include/linux/init.h @@ -62,7 +62,7 @@ #ifdef MODULE #define __exit __attribute__ ((__section__(".exit.text"))) __cold #else -#define __exit __used __attribute__ ((__section__(".exit.text"))) __cold +#define __exit __used __attribute__((__section__(".exit.text"))) __cold #endif /* For assembly routines */ @@ -143,7 +143,7 @@ void prepare_namespace(void); #define console_initcall(fn) \ static initcall_t __initcall_##fn \ - __used __attribute__((__section__(".con_initcall.init")))=fn + __used __attribute__((__section__(".con_initcall.init"))) = fn #define security_initcall(fn) \ static initcall_t __initcall_##fn \ _