From: Andrew Morton ERROR: "(foo*)" should be "(foo *)" #130: FILE: scripts/kallsyms.c:173: + strcmp((char*)s->sym + offset, "_etext")) || ERROR: "(foo*)" should be "(foo *)" #132: FILE: scripts/kallsyms.c:175: + strcmp((char*)s->sym + offset, "_einittext"))) total: 2 errors, 0 warnings, 87 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Benjamin Herrenschmidt Cc: David Woodhouse Cc: Jon Loeliger Cc: Paul Mackerras Cc: Robin Getz Cc: Sam Ravnborg Signed-off-by: Andrew Morton --- scripts/kallsyms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN scripts/kallsyms.c~remove-support-for-un-needed-_extratext-section-checkpatch-fixes scripts/kallsyms.c --- a/scripts/kallsyms.c~remove-support-for-un-needed-_extratext-section-checkpatch-fixes +++ a/scripts/kallsyms.c @@ -170,9 +170,9 @@ static int symbol_valid(struct sym_entry * rules. */ if ((s->addr == _etext && - strcmp((char*)s->sym + offset, "_etext")) || + strcmp((char *)s->sym + offset, "_etext")) || (s->addr == _einittext && - strcmp((char*)s->sym + offset, "_einittext"))) + strcmp((char *)s->sym + offset, "_einittext"))) return 0; } _