From: Andrew Morton ERROR: do not use C99 // comments #114: FILE: drivers/rtc/rtc-ds1302.c:62: + set_dp(get_dp() | RTC_SCLK); // clock high ERROR: do not use C99 // comments #115: FILE: drivers/rtc/rtc-ds1302.c:63: + set_dp(get_dp() & ~RTC_SCLK); // clock low ERROR: do not use C99 // comments #126: FILE: drivers/rtc/rtc-ds1302.c:74: + set_dp(get_dp() | RTC_SCLK); // clock high ERROR: do not use C99 // comments #127: FILE: drivers/rtc/rtc-ds1302.c:75: + set_dp(get_dp() & ~RTC_SCLK); // clock low total: 4 errors, 0 warnings, 281 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alessandro Zummo Cc: Paul Mundt Signed-off-by: Andrew Morton --- drivers/rtc/rtc-ds1302.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/rtc/rtc-ds1302.c~rtc-ds1302-rtc-support-checkpatch-fixes drivers/rtc/rtc-ds1302.c --- a/drivers/rtc/rtc-ds1302.c~rtc-ds1302-rtc-support-checkpatch-fixes +++ a/drivers/rtc/rtc-ds1302.c @@ -59,8 +59,8 @@ static void ds1302_sendbits(unsigned int for (i = 8; (i); i--, val >>= 1) { set_dp((get_dp() & ~RTC_IODATA) | ((val & 0x1) ? RTC_IODATA : 0)); - set_dp(get_dp() | RTC_SCLK); // clock high - set_dp(get_dp() & ~RTC_SCLK); // clock low + set_dp(get_dp() | RTC_SCLK); /* clock high */ + set_dp(get_dp() & ~RTC_SCLK); /* clock low */ } } @@ -71,8 +71,8 @@ static unsigned int ds1302_recvbits(void for (i = 0, val = 0; (i < 8); i++) { val |= (((get_dp() & RTC_IODATA) ? 1 : 0) << i); - set_dp(get_dp() | RTC_SCLK); // clock high - set_dp(get_dp() & ~RTC_SCLK); // clock low + set_dp(get_dp() | RTC_SCLK); /* clock high */ + set_dp(get_dp() & ~RTC_SCLK); /* clock low */ } return val; _