From: Andrew Morton WARNING: braces {} are not necessary for single statement blocks #39: FILE: drivers/char/n_tty.c:783: + if (L_ECHO(tty)) { + echo_char(c, tty); + } total: 0 errors, 1 warnings, 23 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alan Cox Cc: Joe Peterson Signed-off-by: Andrew Morton --- drivers/char/n_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/char/n_tty.c~tty-enable-the-echoing-of-c-in-the-n_tty-discipline-checkpatch-fixes drivers/char/n_tty.c --- a/drivers/char/n_tty.c~tty-enable-the-echoing-of-c-in-the-n_tty-discipline-checkpatch-fixes +++ a/drivers/char/n_tty.c @@ -780,9 +780,8 @@ send_signal: if (tty->driver->flush_buffer) tty->driver->flush_buffer(tty); } - if (L_ECHO(tty)) { + if (L_ECHO(tty)) echo_char(c, tty); - } if (tty->pgrp) kill_pgrp(tty->pgrp, signal, 1); return; _