From: Andrew Morton ERROR: else should follow close brace '}' #55: FILE: arch/um/sys-i386/bugs.c:44: + } + else WARNING: printk() should include KERN_ facility level #56: FILE: arch/um/sys-i386/bugs.c:45: + printk("No\n"); total: 1 errors, 1 warnings, 58 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jeff Dike Cc: Karol Swietlicki Signed-off-by: Andrew Morton --- arch/um/sys-i386/bugs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff -puN arch/um/sys-i386/bugs.c~uml-improve-detection-of-host-cmov-checkpatch-fixes arch/um/sys-i386/bugs.c --- a/arch/um/sys-i386/bugs.c~uml-improve-detection-of-host-cmov-checkpatch-fixes +++ a/arch/um/sys-i386/bugs.c @@ -39,10 +39,9 @@ static void test_for_host_cmov(void) if (setjmp(cmov_test_return) == 0) { unsigned long foo = 0; __asm__ __volatile__("cmovz %0, %1" : "=r" (foo) : "0" (foo)); - printk("Yes\n"); - } - else - printk("No\n"); + printk(KERN_CONT "Yes\n"); + } else + printk(KERN_CONT "No\n"); sigaction(SIGILL, &old, &new); } _